Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gravity
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Peter Harrison
gravity
Commits
609124ab
Commit
609124ab
authored
Feb 26, 2016
by
Peter Harrison
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixing 'high' issues identified by Findbugs.
parent
dac060dc
Changes
8
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
49 additions
and
14 deletions
+49
-14
pom.xml
pom.xml
+29
-7
src/main/java/nz/net/orcon/kanban/controllers/BoardController.java
...java/nz/net/orcon/kanban/controllers/BoardController.java
+1
-1
src/main/java/nz/net/orcon/kanban/controllers/RuleController.java
.../java/nz/net/orcon/kanban/controllers/RuleController.java
+1
-1
src/main/java/nz/net/orcon/kanban/model/Condition.java
src/main/java/nz/net/orcon/kanban/model/Condition.java
+8
-1
src/main/java/nz/net/orcon/kanban/model/Filter.java
src/main/java/nz/net/orcon/kanban/model/Filter.java
+5
-0
src/main/java/nz/net/orcon/kanban/model/Operation.java
src/main/java/nz/net/orcon/kanban/model/Operation.java
+3
-1
src/main/java/nz/net/orcon/kanban/security/SecurityTool.java
src/main/java/nz/net/orcon/kanban/security/SecurityTool.java
+1
-1
src/main/java/nz/net/orcon/kanban/tools/ListTools.java
src/main/java/nz/net/orcon/kanban/tools/ListTools.java
+1
-2
No files found.
pom.xml
View file @
609124ab
...
...
@@ -442,11 +442,33 @@
<reporting>
<plugins>
<plugin>
<groupId>
org.codehaus.mojo
</groupId>
<artifactId>
findbugs-maven-plugin
</artifactId>
<version>
3.0.3
</version>
</plugin>
</plugins>
</reporting>
<plugin>
<groupId>
org.codehaus.mojo
</groupId>
<artifactId>
findbugs-maven-plugin
</artifactId>
<version>
3.0.3
</version>
</plugin>
<plugin>
<groupId>
org.apache.maven.plugins
</groupId>
<artifactId>
maven-project-info-reports-plugin
</artifactId>
<version>
2.7
</version>
<configuration>
<dependencyLocationsEnabled>
false
</dependencyLocationsEnabled>
</configuration>
</plugin>
<plugin>
<groupId>
org.codehaus.mojo
</groupId>
<artifactId>
cobertura-maven-plugin
</artifactId>
<version>
2.6
</version>
<configuration>
<formats>
<format>
html
</format>
<format>
xml
</format>
</formats>
</configuration>
</plugin>
</plugins>
</reporting>
</project>
src/main/java/nz/net/orcon/kanban/controllers/BoardController.java
View file @
609124ab
...
...
@@ -73,7 +73,7 @@ public class BoardController {
private
static
final
Logger
logger
=
LoggerFactory
.
getLogger
(
BoardController
.
class
);
public
static
String
BOARD
=
"BOARD"
;
public
static
final
String
BOARD
=
"BOARD"
;
@Resource
(
name
=
"ocmFactory"
)
OcmMapperFactory
ocmFactory
;
...
...
src/main/java/nz/net/orcon/kanban/controllers/RuleController.java
View file @
609124ab
...
...
@@ -62,7 +62,7 @@ public class RuleController {
private
static
final
Logger
logger
=
LoggerFactory
.
getLogger
(
RuleController
.
class
);
public
static
String
RULE
=
"RULE"
;
public
static
final
String
RULE
=
"RULE"
;
@Resource
(
name
=
"ocmFactory"
)
OcmMapperFactory
ocmFactory
;
...
...
src/main/java/nz/net/orcon/kanban/model/Condition.java
View file @
609124ab
...
...
@@ -21,13 +21,20 @@
package
nz.net.orcon.kanban.model
;
import
java.io.Serializable
;
import
org.apache.jackrabbit.ocm.manager.enumconverter.EnumTypeConverter
;
import
org.apache.jackrabbit.ocm.mapper.impl.annotation.Field
;
import
org.apache.jackrabbit.ocm.mapper.impl.annotation.Node
;
@Node
public
class
Condition
{
public
class
Condition
implements
Serializable
{
/**
*
*/
private
static
final
long
serialVersionUID
=
1L
;
@Field
private
String
fieldName
;
...
...
src/main/java/nz/net/orcon/kanban/model/Filter.java
View file @
609124ab
...
...
@@ -32,6 +32,11 @@ import org.apache.jackrabbit.ocm.mapper.impl.annotation.Node;
@Node
public
class
Filter
extends
AbstractNamedModelClass
implements
Serializable
{
/**
*
*/
private
static
final
long
serialVersionUID
=
1L
;
@Field
private
String
expression
;
...
...
src/main/java/nz/net/orcon/kanban/model/Operation.java
View file @
609124ab
...
...
@@ -21,7 +21,9 @@
package
nz.net.orcon.kanban.model
;
public
enum
Operation
{
import
java.io.Serializable
;
public
enum
Operation
implements
Serializable
{
CONTAINS
(
"contains"
,
"jcr:contains(fields/@${field},'${value}')"
),
EQUALTO
(
"equal to"
,
"fn:lower-case(fields/@${field})='${value}'"
),
...
...
src/main/java/nz/net/orcon/kanban/security/SecurityTool.java
View file @
609124ab
...
...
@@ -47,7 +47,7 @@ public class SecurityTool {
private
static
final
Logger
LOG
=
LoggerFactory
.
getLogger
(
SecurityTool
.
class
);
public
static
String
SYSTEM
=
"system"
;
public
static
final
String
SYSTEM
=
"system"
;
@Autowired
TeamCache
teamCache
;
...
...
src/main/java/nz/net/orcon/kanban/tools/ListTools.java
View file @
609124ab
...
...
@@ -110,8 +110,7 @@ public class ListTools {
String
filterId
,
ObjectContentManager
ocm
){
Filter
filter
=
(
Filter
)
ocm
.
getObject
(
Filter
.
class
,
String
.
format
(
URI
.
FIELDS_URI
,
boardId
,
filterId
));
Filter
filter
=
(
Filter
)
ocm
.
getObject
(
Filter
.
class
,
String
.
format
(
URI
.
FILTER_URI
,
boardId
,
filterId
));
QueryManager
qm
=
ocm
.
getQueryManager
();
org
.
apache
.
jackrabbit
.
ocm
.
query
.
Filter
qmFilter
=
qm
.
createFilter
(
Card
.
class
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment