Findbugs changes.

src/main/java/nz/net/orcon/kanban/controllers/TeamCache.java

@@ -62,9 +62,11 @@ public class TeamCache extends CacheImpl<Team> {
 	@Override
 	protected Map<String, String> getListFromStore(String... prefixs) throws Exception {
 		
-		String pre = Integer.toString(prefixs.length) + " - ";
+		StringBuffer pre = new StringBuffer();
+		pre.append(Integer.toString(prefixs.length) + " - ");
 		for( int x=0; x < prefixs.length; x++){
-			pre = pre + prefixs[x] + ", ";
+			pre.append(prefixs[x]);
+			pre.append(", ");
 		}
 		logger.info("Prefixs: " + pre);
 		

src/main/java/nz/net/orcon/kanban/model/TemplateGroup.java

@@ -66,9 +66,8 @@ public class TemplateGroup extends AbstractNamedModelClass implements Serializab
 			sorted.put(entry.getValue().getIndex(), entry.getValue());
 		}
 		this.fields = new LinkedHashMap<String,TemplateField>();
-		for( Integer key: sorted.keySet()){
-			TemplateField field = sorted.get(key);
-			this.fields.put(field.getId(), field);
+		for( Entry<Integer,TemplateField> entry: sorted.entrySet()){
+			this.fields.put(entry.getValue().getId(), entry.getValue());
 		}
 	}
 

src/main/java/nz/net/orcon/kanban/tools/CardConverter.java

@@ -174,16 +174,16 @@ public class CardConverter implements Converter{
 	    }
 		card.setFields(map);
 		if("tasks".equalsIgnoreCase(reader.getNodeName())){
-			card.setTasks(new Long(reader.getValue()));
+			card.setTasks(Long.valueOf(reader.getValue()));
 		}
 		if("history".equalsIgnoreCase(reader.getNodeName())){
-			card.setHistory(new Long(reader.getValue()));
+			card.setHistory(Long.valueOf(reader.getValue()));
 		}
 		if("comments".equalsIgnoreCase(reader.getNodeName())){
-			card.setComments(new Long(reader.getValue()));
+			card.setComments(Long.valueOf(reader.getValue()));
 		}
 		if("alerts".equalsIgnoreCase(reader.getNodeName())){
-			card.setAlerts(new Long(reader.getValue()));
+			card.setAlerts(Long.valueOf(reader.getValue()));
 		}	
 		return card;
 	}

src/main/java/nz/net/orcon/kanban/tools/CardToolsImpl.java

@@ -263,8 +263,6 @@ public class CardToolsImpl implements CardTools{
 		
 		Map<Integer,String> phaseIndexMap = new TreeMap<Integer,String>();
 		
-		Set<String> keySet = phases.keySet();
-		
 		for( Entry<String,Phase> entry : phases.entrySet()){
 			phaseIndexMap.put(entry.getValue().getIndex(),entry.getKey());
 		}

src/main/java/nz/net/orcon/kanban/tools/RepositoryIndexInitializer.java

@@ -17,8 +17,7 @@ public class RepositoryIndexInitializer implements RepositoryInitializer{
 		ImmutableList fields = 
 				ImmutableList.builder().add( "id","name" ).build(); 
 
-		NodeBuilder indexNodebuilder = 
-				IndexUtils.createIndexDefinition(index, "gravityIndexes", true, false, fields, null); 
+		IndexUtils.createIndexDefinition(index, "gravityIndexes", true, false, fields, null); 
 		
 	}
 }